UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-22 15:20:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

[escher] Fix responder order bug.

Browse Source 
EditableExpressionView cannot pass the first responder state to one of
its children, otherwise Calculation::EditableExpressionView's overriden
handleEvent method is never called.

Change-Id: Id2b56b9501e67431e860573cf4c62a16651c3958
This commit is contained in:
Léa Saviot
2018-01-24 10:20:09 +01:00
parent b9a7973961
commit f38bbff447
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
escher/include/escher/editable_expression_view.h
View File

@@ -30,7 +30,6 @@ public:
KDSize minimalSizeForOptimalDisplay() const override;
/* Responder */
void didBecomeFirstResponder() override;
bool handleEvent(Ion::Events::Event event) override;
static constexpr int k_bufferLength = TextField::maxBufferSize();

8
escher/src/editable_expression_view.cpp
View File

@@ -88,14 +88,6 @@ void EditableExpressionView::drawRect(KDContext * ctx, KDRect rect) const {
}
}
void EditableExpressionView::didBecomeFirstResponder() {
if (editionIsInTextField()) {
app()->setFirstResponder(&m_textField);
return;
}
app()->setFirstResponder(&m_scrollableExpressionViewWithCursor);
}
bool EditableExpressionView::handleEvent(Ion::Events::Event event) {
return editionIsInTextField() ? m_textField.handleEvent(event) : m_scrollableExpressionViewWithCursor.handleEvent(event);
}