[apps/ion] Factorize code and TODO

This commit is contained in:
Léa Saviot
2019-08-07 10:51:52 +02:00
parent 5a68c52120
commit f5a7a44546
4 changed files with 9 additions and 10 deletions

View File

@@ -25,11 +25,12 @@ int POSTAndHardwareTests::LCDDataGlyphFailures() {
int POSTAndHardwareTests::LCDTimingGlyphFailures() {
int numberOfFailures = 0;
const int rootNumberTiles = 3; //TODO 1 ?
for (int i = 0; i < 100; i++) {
Ion::Display::POSTPushMulticolor(k_stampSize);
Ion::Display::POSTPushMulticolor(rootNumberTiles, k_stampSize);
KDColor stamp[k_stampSize*k_stampSize];
for (int i = 0; i < 3; i++) { // TODO LEA 1?
for (int j = 0; j < 3; j++) {
for (int i = 0; i < rootNumberTiles; i++) {
for (int j = 0; j < rootNumberTiles; j++) {
Ion::Display::pullRect(KDRect(i * k_stampSize, j * k_stampSize, k_stampSize, k_stampSize), stamp);
int shift = (i+j) % 16;
uint16_t color = (uint16_t)(1 << shift);

View File

@@ -31,7 +31,7 @@ constexpr int HeightInTenthOfMillimeter = 432;
// For Power On Self tests
int displayUniformTilingSize10(KDColor c);
int displayColoredTilingSize10();
void POSTPushMulticolor(int tileSize);
void POSTPushMulticolor(int rootNumberTiles, int tileSize);
}
}

View File

@@ -86,11 +86,9 @@ bool waitForVBlank() {
return false;
}
void POSTPushMulticolor(int tileSize) {
const int maxI = 3; // TODO 1 ?
const int maxJ = 3;
for (int i = 0; i < maxI; i++) {
for (int j = 0; j < maxJ; j++) {
void POSTPushMulticolor(int rootNumberTiles, int tileSize) {
for (int i = 0; i < rootNumberTiles; i++) {
for (int j = 0; j < rootNumberTiles; j++) {
uint16_t k = (i+j) % 16;
uint16_t color = 1 << k;
setDrawingArea(KDRect(i*tileSize,j*tileSize,tileSize, tileSize), Orientation::Landscape);

View File

@@ -1,6 +1,6 @@
#include <ion/display.h>
void Ion::Display::POSTPushMulticolor(int tileSize) {
void Ion::Display::POSTPushMulticolor(int rootNumberTiles, int tileSize) {
}
int displayUniformTilingSize10(KDColor c) {