UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-25 08:41:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare] Handle real fractions apart from complex fractions

Browse Source 
Change-Id: I0caa905c8ddc4a85db31a0dc5e5bc4ffd49c31c4
This commit is contained in:
Émilie Feral
2017-06-14 12:20:31 +02:00
parent 0364f9494c
commit f7817a79ae
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
poincare/src/fraction.cpp
View File

@@ -34,6 +34,13 @@ Expression::Type Fraction::type() const {
Expression * Fraction::evaluateOnComplex(Complex * c, Complex * d, Context& context, AngleUnit angleUnit) const {
float norm = d->a()*d->a() + d->b()*d->b();
/* We handle the case of c and d pure real numbers apart. Even if the complex
* fraction is mathematically correct on real numbers, it requires more
* operations and is thus more likely to propagate errors due to float exact
* representation. */
if (d->b() == 0.0f && c->b() == 0.0f) {
return new Complex(Complex::Float(c->a()/d->a()));
}
return new Complex(Complex::Cartesian((c->a()*d->a()+c->b()*d->b())/norm, (d->a()*c->b()-c->a()*d->b())/norm));
}