Commit Graph

1106 Commits

Author SHA1 Message Date
Léa Saviot
759fa6a60a [escher] Fix constexpr due to linux warning 2020-07-02 17:09:38 +02:00
Émilie Feral
736833da34 [escher] Typo 2020-06-26 17:48:31 +02:00
Émilie Feral
1da2f23914 [escher] SelectableTableView: fix delegate notification when
deselecting table view

This fixes the following bug: input 1.2/2, OK, up, down, the exact ouput
is still displayed but should have toggled
2020-06-26 17:48:31 +02:00
Émilie Feral
bac2949a5e [escher][apps] SelectableTableViewDelegate: add
tableViewDidChangeSelectionAndDidScroll method and implement it for
Calculation::HistoryController

This fixes the following bug: In the calculation application, input 1,
OK, 1/2/3/4/5/6/7/8, OK, up, up, left, down, up. The selection failed.
2020-06-25 13:48:47 +02:00
Arthur
59bf8bbcf4 [matplotlib] Added cyan color to the color palette
Change-Id: I29476d8148ad98285505adc460b90628573518fa
2020-06-04 14:50:09 +02:00
Émilie Feral
5725ba1c14 [escher] LayoutField: reset selection when clearing layout 2020-06-04 14:50:08 +02:00
Émilie Feral
9a3e2c960f [escher] LayoutField: update the grey squares when using insertion
cursor
2020-06-04 14:50:08 +02:00
Émilie Feral
79e7626dc3 [escher] LayoutField: the insertion cursor can't point to an EmptyLayout
as it might be destroyed

This fixes the following crash: input 1, OK, input ans/[], go up to the history --> crash
2020-06-04 14:50:08 +02:00
Émilie Feral
465fa5c63f [escher] TextField: fix insertTextAtLocation (confusion between size and
length)

This fixes the following bug: in a textfield, input '000', clear, input
'00', backspace --> crash
2020-06-04 14:50:08 +02:00
Léa Saviot
b096d6f5e4 [escher/table_view] COding style 2020-06-04 14:50:08 +02:00
Léa Saviot
44af4b1fde [escher/table_view] Fix numberOfDisplayableRows/Columns
Did not take into account the margin so was too big sometimes
2020-06-04 14:50:08 +02:00
Léa Saviot
515aa543d3 [escher/table_view] Remove dead code 2020-06-04 14:50:08 +02:00
Léa Saviot
12a45ef8e6 [escher/poincare] Coding style 2020-06-04 14:50:08 +02:00
Léa Saviot
9d5e58f32b [escher/scroll_view] Do not compute offset if view invisible 2020-06-04 14:50:08 +02:00
Léa Saviot
3e4478454c [escher] Avoid useless redrawing in ExpressionView::setLayout 2020-06-04 14:50:08 +02:00
Léa Saviot
5f26ca40cc [apps/escher] Fix scroll view indicator margin
So it does not overflow the scrolled view. Fixed for the language
controllers (on boarding app and settings), one value was changed from a
magic 14 to Metric::CommonTopMargin = 15, it did not seem to break
anything.
2020-06-04 14:50:07 +02:00
Léa Saviot
f306b51fc5 [apps/escher] Move ModalViewEmptyController to escher 2020-06-04 14:50:06 +02:00
Léa Saviot
6d7b294bca [apps/escher] Rename ToolboxMessageTree::children -> childAtIndex 2020-06-04 14:50:06 +02:00
Léa Saviot
bba5b237d2 [apps/code] Display different varbox titles from editor and console 2020-06-04 14:50:06 +02:00
Léa Saviot
0f2ac5b110 [escher/text_field] Fix std::min use 2020-06-04 14:50:05 +02:00
Léa Saviot
a165c6d85b [escher] Clean InputEventHandler 2020-06-04 14:50:05 +02:00
Léa Saviot
33d8d10286 [apps/code] Do not select subtitles in the variable box 2020-06-04 14:50:05 +02:00
Léa Saviot
0d6016116d [apps/code] Cosmetic fixes on the variable box 2020-06-04 14:50:05 +02:00
Léa Saviot
b3d87c0e18 [escher/stack_view_controller] Inline some methods 2020-06-04 14:50:05 +02:00
Léa Saviot
96d68d6b44 [apps/code/varbox] Subtitles and basic items are displayed properly 2020-06-04 14:50:05 +02:00
Léa Saviot
0863abc4da [apps/code] VariableBox cells with node origins 2020-06-04 14:50:05 +02:00
Léa Saviot
52644bf76d [apps/code] Subtitles in the variable box 2020-06-04 14:50:05 +02:00
Léa Saviot
6311f408b4 [escher/text_area] Fix overlap in textInsert 2020-06-04 14:50:04 +02:00
Léa Saviot
fd1b0e08ee [escher/text_field] Fix insertion size computation 2020-06-04 14:50:04 +02:00
Léa Saviot
eeb42f2544 [apps/code] autocompletionText uses the right text length
Before, there was no notion that the autocompleted text might not be a
null terminated string.
2020-06-04 14:50:03 +02:00
Léa Saviot
938e0dd840 [apps/code] Autocompletion steps 2020-06-04 14:50:03 +02:00
Léa Saviot
a56a73b0ba [apps/calculation] Fix calculation height computation
It was done in two places before, which created inconsistencies
2020-05-28 04:44:27 -07:00
Léa Saviot
016f87c266 [escher/layout_field] Reset the scroll when clearing the layout
Scenario: Go to the graph app, create f(x) = 1 then create g(x) -> there
is a weird big margin in the edition field
2020-05-15 02:39:11 -07:00
Romain Goyet
fc4b0a8d35 [escher] Add an insertionField in LayoutField 2020-05-11 10:34:28 +02:00
Émilie Feral
675a0d3f4c Add missing definition of static member variables 2020-04-15 10:34:00 -04:00
Romain Goyet
84768472bd Explicit std::min/max template usage
This is unfortunately required in several cases:
 - Sometimes when we use either float and double (this should be changed)
 - Because KDCoordinate is not an int, so any arithmemtic promotes it to
an int
 - Because we mix pointer differences and ints
2020-04-14 09:31:02 -04:00
Romain Goyet
950862f8d0 Use std::min and std::max 2020-04-14 09:31:02 -04:00
Romain Goyet
64a1094edf [escher/layout_field] Use IsMoveEvent 2020-04-09 09:47:43 +02:00
Romain Goyet
ec4def61c3 [escher/layout_field] Avoid calling the same method over and over again 2020-04-09 09:47:43 +02:00
Jean-Baptiste Boric
2768ac2b48 [escher] Remove statically-allocated buffers 2020-04-08 10:09:47 +02:00
Romain Goyet
743eb104bf [ion] Replace Ion::Events::Event::id() by an explicit cast operator 2020-04-08 09:56:33 +02:00
Romain Goyet
35d446353f [escher] Avoid long switches on Left/Up/Right/Down 2020-04-08 09:56:33 +02:00
Émilie Feral
d0c5ac0343 [escher] StackViewController: add a method to return the
topViewController
2020-04-01 10:18:09 +02:00
Émilie Feral
886fc98350 [escher] Palette: factorize data color iteration 2020-04-01 10:18:08 +02:00
Romain Goyet
df5c0752fb [escher] Remove a useless header 2020-03-26 09:31:58 +01:00
Ruben Dashyan
d64e58b9dc [escher/transparent_view] Remove redundancy 2020-03-10 11:11:57 +01:00
Émilie Feral
94daf465c4 [escher][apps/calculation] Improve ScrollView::scrollToContentRect to
scroll "smartly" when scrolling to a too-big-to-be-displayed rect

This fixes calculation history navigation on big cells (that are bigger
than the displayed table)
2020-02-20 10:56:11 +01:00
Léa Saviot
92378b9496 [escher/layout_field] Handle Cut events 2020-02-18 10:08:34 +01:00
Léa Saviot
9544f1c961 [apps/eschr] Don't copy an expr when editing it, if it is too long
Scenario: Create a new sequence which is the multiplication of a lot of
imaginary i. Save it (many multiplication sign are added), then try to
edit it again, in linear edition mode: the text overflows the buffer. If
we still copied it, it might get copied until the middle of a code point,
which would make the UTF8Decoder crash afterwards.
2020-02-18 10:06:36 +01:00
Romain Goyet
b06de12902 [escher] Add a telemetry API based off ion's 2020-02-17 10:31:24 -05:00