Commit Graph

4201 Commits

Author SHA1 Message Date
Émilie Feral
73a8ec24f2 [calculation] Revert "HistoryViewCell: remove useless m_expandedCalculation"
When scrolling up and down, only 'setCalculation' is called by
'willDisplayCellForIndex' - and not 'cellDidSelectSubview'. So a new cell
should be informed of the expanded state in 'setCalculation'.
2020-02-12 15:13:20 +01:00
Émilie Feral
80d8e8eead Coding style 2020-02-12 15:13:20 +01:00
Émilie Feral
c47394ae22 [calculation] (revert previous commit) HistoryViewCell: setCalculation
should decide which subviews is displayed.
'setCalculation' is the only method called when scrolling (when using
a new cell for a calculation) so it should take into accound whether the
cell is expanded or not.

This fixes the bug: when pushing several calculations (which expand) in
the store, scrolling up and down corrupts the cells contents
2020-02-12 15:13:20 +01:00
Émilie Feral
c12304a00e [calculation] Remove outdated comment 2020-02-12 15:13:20 +01:00
Émilie Feral
6a2f11ef1b [escher] ExpressionTableCell & ExpressionTableCellWithExpression:
reloadScroll when displaying cell
2020-02-12 15:13:20 +01:00
Émilie Feral
8a07d335a3 [calculation] Additional Ouputs: speed up scrolling in
ExpressionsListController by memoizing layouts. Avoid glitering
2020-02-12 15:13:20 +01:00
Émilie Feral
4bd3dfd542 [escher] TableCell: the subviews are layoutted horizontally or
vertically. We add an option to decide which subviews should overlap on
top of the other if there is not enough space
2020-02-12 15:13:20 +01:00
Émilie Feral
5974149162 [escher] Metric: change name TableCellLabelTopMargin to
TableCellHorizontalMargin and add TableCellHorizontalMargin
2020-02-12 15:13:20 +01:00
Émilie Feral
9312d2bd65 [escher] ExpressionTableCell is composed of a ScrollableExpressionView
instead of an ExpressionView
2020-02-12 15:13:19 +01:00
Émilie Feral
9301dd510a [calculation][escher] Move ScrollableExpressionView from apps/calculation/ to
escher/
2020-02-12 15:13:19 +01:00
Émilie Feral
70ce133b4c [calculation] Change name: simple_list_controller -->
expressions_list_controller
2020-02-12 15:13:19 +01:00
Émilie Feral
7abe8e2e4d [calculation] ScrollableInputExactApproximateExpressionsCell: margins
are controlled by the scrollview instead of TableCell in order to
display arrows indicator correctly
2020-02-12 15:13:19 +01:00
Émilie Feral
10c906e5e2 [shared] AbstractScrollableExactApproximateExpressionsView: when the
left subview is selected, reload the scroll to display the left view
2020-02-12 15:13:19 +01:00
Émilie Feral
acd9e63cbd [shared] AbstractScrollableExactApproximateExpressionsView: fix
setDisplayLeft and setDisplayCenter to re-layoutSubviews
2020-02-12 15:13:19 +01:00
Émilie Feral
7e96ccf5a6 [shared] Typo 2020-02-12 15:13:19 +01:00
Émilie Feral
c6efb99e05 [calculation] ScrollableInputExactApproximateExpressionsCell: select the
left expression when the cell becomes first responder
2020-02-12 15:13:19 +01:00
Émilie Feral
d8d0f33b1b [calculation] ExpressionWithEqualSignView: add a margin between
expression and equal sign
2020-02-12 15:13:19 +01:00
Émilie Feral
85ba8f8076 [calculation] RationalListController: display MixedFraction layout 2020-02-12 15:13:19 +01:00
Émilie Feral
40996deb0a [calculation] RationalListController: use
Integer::CreateEuclideanDivision to build layout
2020-02-12 15:13:19 +01:00
Émilie Feral
f47a18bf4a [calculation] Remove useless includes 2020-02-12 15:13:19 +01:00
Émilie Feral
df47a355a2 [calculation] HistoryController: display RationalListController when
clicking on a burger of a Rational input
2020-02-12 15:13:19 +01:00
Émilie Feral
54f1984cf0 [calculation] Create a class RationalListController 2020-02-12 15:13:19 +01:00
Émilie Feral
47e7a8407b [calculation] WIP: add messages for RationalListController 2020-02-12 15:13:19 +01:00
Émilie Feral
f94727b62d [calculation] HistoryController: factorize code 2020-02-12 15:13:19 +01:00
Émilie Feral
1dae85694f [calculation] IllustratedListController: empty calculation store before
reloading it
2020-02-12 15:13:19 +01:00
Émilie Feral
847eb8d907 [calculation] Create a class ListController to factorize
IllustratedListController and SimpleListController
2020-02-12 15:13:19 +01:00
Émilie Feral
714e5f12d9 [calculation] WIP: display IntegerListController when clicking on a
burger view of an integer input
2020-02-12 15:13:19 +01:00
Émilie Feral
51d5fc0473 [calculation] AdditionalOutputs: Create a IntegerListController 2020-02-12 15:13:19 +01:00
Émilie Feral
8d40ef8ccb [calculation] Add sketch messages for IntegerListController 2020-02-12 15:13:19 +01:00
Émilie Feral
80100b62af [calculation] Additional outputs: Create a class SimpleListController.
Future IntegerListController and RationalListController will inherit
from it
2020-02-12 15:13:19 +01:00
Émilie Feral
49d52f293e [calculation] First version of the TrigonometryListController 2020-02-12 15:13:19 +01:00
Émilie Feral
83a29a822b [calculation] Improve ComplexListController 2020-02-12 15:13:19 +01:00
Émilie Feral
715a1a2d5e [calculation] AdditionalInformation are base on the Calculation input
instead of exact output
2020-02-12 15:13:19 +01:00
Émilie Feral
1eb0744caa [calculation] IllustratedListController: fix setExpression (use virtual
symbol)
2020-02-12 15:13:19 +01:00
Émilie Feral
a75acf6f87 [calculation] IllustratedListController: fix numberOfRows 2020-02-12 15:13:19 +01:00
Émilie Feral
d178adc936 [apps/calculation] Improve expressions that are displayed in Complex
pop-up
2020-02-12 15:13:19 +01:00
Émilie Feral
d698af035c [calculation] ScrollableInputExactApproximateExpressionsView: improve
margins, background color, size
2020-02-12 15:13:19 +01:00
Émilie Feral
157aa206c6 [calculation] Calculation: add a parameter to height to compute the
height of the calculation cell with all expressions inlined
2020-02-12 15:13:19 +01:00
Émilie Feral
52ac7b1a94 [calculation] IllustratedListController: fix first responder when
IllustratedListController becomes first responder
2020-02-12 15:13:19 +01:00
Émilie Feral
24873ef730 [calculation] IllustratedListController: forbid selection of the
illustration cell
2020-02-12 15:13:19 +01:00
Émilie Feral
79a84d1044 [calculation] Add an equal sign in
ScrollableInputExactApproximateExpressionsCell
2020-02-12 15:13:19 +01:00
Émilie Feral
f850226341 [calculation] Fix ScrollableInputExactApproximateExpressionsView margins 2020-02-12 15:13:19 +01:00
Émilie Feral
dcdc5ac879 [calculation] ScrollableInputExactApproximateExpressionsCell inherits
from TableCell to draw borders
2020-02-12 15:13:18 +01:00
Émilie Feral
d1439c2453 [calculation] ScrollableInputExactApproximateExpressionsCell is a
responder
2020-02-12 15:13:18 +01:00
Émilie Feral
90033a54c0 [shared] Avoid extra function call 2020-02-12 15:13:18 +01:00
Émilie Feral
c7ae89fcba [calculation] Additional outputs: display left and center subviews of
InputExactApproximateExpressionsView in the additional output pop-up
2020-02-12 15:13:18 +01:00
Émilie Feral
eac83fce0b [calculation] Improve margins of additional results pop-up 2020-02-12 15:13:18 +01:00
Émilie Feral
2ebbe5ae25 [calculation] WIP: first version of ComplexListController 2020-02-12 15:13:18 +01:00
Émilie Feral
47e4abee81 [apps/calculation] Reload display output when HistoryController appears
(to avoid displaying 2 = 2 when leaving and reentering Calculation app)
2020-02-12 15:13:18 +01:00
Émilie Feral
ec0c7c0384 [apps/calculation] Create ScrollableInputExactApproximateExpressionsView
inheriting from Shared::ScrollableExactApproximateExpressionsView
2020-02-12 15:13:18 +01:00