Commit Graph

11498 Commits

Author SHA1 Message Date
Léa Saviot
f3628f368f [poincare/expression] Return undef if simplification interrupted
Without this change, we would get weird "reduced" expression, such as
multiplication(undef, _s), but we do not always check
sSimplificationHasBeenInterrupted afterwards.
2020-07-29 10:13:19 +02:00
Hugo Saint-Vignes
5c75cc55d3 [apps/shared] Apply changes on confirm with GoTo functions
Change-Id: I6ebec412b4b6612710476274a8665375d21f9ef8
2020-07-29 10:07:07 +02:00
Hugo Saint-Vignes
61792058d3 [apps/shared] Fix typos for Interval and curve view temporary params
Change-Id: I610726ed5966d353397be923b76dd003297940a7
2020-07-29 10:07:07 +02:00
Joachim LF
d37bf9e344 [Apps/Shared] Fixed interval and curve view exit 2020-07-29 10:07:07 +02:00
Émilie Feral
b4a3dd10e1 [apps/shared] ToolBoxHelpers: don't overflow buffer
If the commandLength is > than the buffer size, we have to escape at
some point to avoid overflowing the buffer.
2020-07-29 09:43:51 +02:00
Léa Saviot
3e6e1729a2 [ion/device] Add screen id for gamma calibration 2020-07-20 10:35:59 +02:00
Émilie Feral
22549d4d50 [apps/calculation] CalculationStore: change name CalculationHeight -->
HeightComputer
2020-07-16 14:37:38 +02:00
Émilie Feral
83ecefda00 [apps/calculation] Fix tests 2020-07-16 14:37:38 +02:00
Émilie Feral
1fb8c09714 [apps/calculation] Remove old TODOs 2020-07-16 14:37:38 +02:00
Émilie Feral
df74c2c551 [apps/calculation] The heights (common and expanded) of calculation cells are
computed when the calculation is added to the store and don't change afterwards.
Otherwise, if their heights change when scrolling (due to a modification of the
display output type - ExactOnly, ApproximateOnly...), it generates crashes.
2020-07-16 14:37:38 +02:00
Émilie Feral
c2db00cc88 [apps/calculation] When leaving calculation app, do not invalid
calculation height memoization. They're computed from the layouts which
don't depend on the complex format (or any other settings parameters
which could have changed).
2020-07-16 14:37:38 +02:00
Léa Saviot
708477dece [apps/i18n] Fix missing upper case 2020-07-16 11:53:12 +02:00
Léa Saviot
b4dd4b5e7e [apps/code/i18n] Make italian wording fit 2020-07-16 11:53:12 +02:00
Léa Saviot
c20261940f [poincare] Handle removeUnit that create Undefined expressions
UnitConvert::removeUnit replaces the unit ocnvert with an undefined.
2020-07-16 11:46:23 +02:00
Léa Saviot
3a046f5bcb [poincare/multiplication] Fix Multiplication::removeUnit
Scenario:
f(x) = 0->_A
evaluate 0f(0)
2020-07-16 11:46:23 +02:00
Léa Saviot
36bc70aaee [poincare/power] Better Power::shallowReduce
Take care of an undefined index that arrived during the remove unit
2020-07-16 11:46:23 +02:00
Léa Saviot
9e94304db0 [poincre/test] Rename assert_simplify -> assert_reduce
And assert_expression_simplify -> assert_expression_reduce
2020-07-16 11:46:23 +02:00
Émilie Feral
c92b3d49e9 [apps/calculation] HistoryController: reload the subview selection when
deleting row

This fixes the following bug: input 1, OK, 1.2 OK, delete the row whose
input is '1' with the selection on the output view. The output of 1.2
does not toggle and it should.
2020-07-16 09:48:22 +02:00
Léa Saviot
43744bcae9 [poincare/power] Fix shallowReduce
Scenario: f(x) = 0->0
In graph, go to x = e^(f(0))
2020-07-15 13:07:17 +02:00
Joachim Le Fournis
46ede2eb59 Resolved the wrong gender of font in fr 2020-07-15 10:41:37 +02:00
Charlotte THOMAS
b5f9deb169 Update calculation.cpp
removed white
2020-07-15 10:28:15 +02:00
Charlotte THOMAS
7754693bdf fix: change IsIS => IsSI in test too 2020-07-15 10:28:15 +02:00
Charlotte THOMAS
f1dab081e1 Fix: CI test 2020-07-15 10:28:15 +02:00
Charlotte THOMAS
9d8b62894f Fix: Changed "IS" to "SI" because even in english the short for "International System of Units" is "SI" 2020-07-15 10:28:15 +02:00
Léa Saviot
b83c686773 build: Version 14.4.1 2020-07-10 10:49:19 +02:00
Léa Saviot
2af89fb546 [build/android] Prevent code relocations in MicroPython 2020-07-09 20:24:16 -04:00
Léa Saviot
1fde815769 [ion/android] Do not setWindowStyle if SDL not initialized
When a library was broken, we would see an error due to the failed
setWindowStyle call, instead of getting the briken library error.
2020-07-09 20:24:16 -04:00
Léa Saviot
ef8a4f9e7b build: Version 14.4.0 2020-07-07 09:55:21 +02:00
Léa Saviot
d8f17da04e [apps/calculation] Add TODO comments about factorization 2020-07-07 09:55:20 +02:00
Léa Saviot
cc4ff3d40d [apps/calculation] Apply fix about Height computation
There was a problem with the way of computing Height, see
Calculation::HistoryViewCell. We did not encounter a problemeatic
scenario here, but there is no reason it would have been safe before.
2020-07-07 09:55:20 +02:00
Léa Saviot
982b467268 [apps/calculation] Fix scrolling
If the last cell is too big to fit entirely, we would scroll to the top
of the calculation, instead of the bottom
2020-07-07 09:46:26 +02:00
Léa Saviot
1128134c37 [apps/calculation] Raise exception if row height miscomputed
Scenario:
Put the complex mode to exponential, then go back to Calculation and:
Toolbox, Down, Down, Down, Down, OK, OK, Two, Plus, Imaginary,
Toolbox, Down, Down, Down, Down, OK, Down, OK, Two, Plus,
Imaginary, OK, Toolbox, Down, Down, Down, Down, Down, OK,
Down, OK, Up, OK, Right, Zero, OK, OK, Toolbox, Down,
Down, OK, Toolbox, Back, Up, Zero, Up, OK, Zero, Up, Up, Up
2020-07-07 09:46:26 +02:00
Léa Saviot
924e235ba8 [apps/calculation] Factorize some code 2020-07-06 17:16:22 +02:00
Léa Saviot
35f20c4312 [apps/calculation] Comment possible failed height computation 2020-07-06 16:35:35 +02:00
Léa Saviot
1ef3f34a31 [ion/apple] App needs to be inside Payload folder to build .ipa
Otherwise the .ipa cannot be uploaded to the app store.
2020-07-03 14:21:56 +02:00
Émilie Feral
38f3c9b813 build: Version 14.3.0 2020-07-02 17:09:38 +02:00
Léa Saviot
759fa6a60a [escher] Fix constexpr due to linux warning 2020-07-02 17:09:38 +02:00
Léa Saviot
6b60fc561f [apps/regression] Fix wrong proportional model fit 2020-07-02 17:09:38 +02:00
Romain Goyet
5dfccd4a04 [ion/simulator] Relayout on any windows event
We might be relayouting a bit too often, but better safe than sorry!
Jokes aside, most SDL_WINDOWEVENT should trigger a relayout, and in
general those events aren't triggered on a regular basis anyway.
2020-07-02 14:42:59 +02:00
Romain Goyet
7a9954152a [ion/simulator] Ion::Simulator::Main::relayout() should not draw
That function is supposed to recompute the layout, not perform any
drawing. Namely, presenting the render without a potential previous call
to SDL_RenderClear could lead to some visual glitches.
2020-07-02 14:42:59 +02:00
Romain Goyet
026fe120fe [simulator] Make the calculator's screen pixel-perfect 2020-07-02 14:42:59 +02:00
Émilie Feral
558d0f6343 [.github/workflow] ci-workflow: fix emscripten version to 1.39.16 (later
versions removed EMTERPRETER)
2020-07-02 14:42:59 +02:00
Léa Saviot
3cf80b86d6 [apps/i18n] Fix italian translation typo 2020-07-02 10:23:27 +02:00
Léa Saviot
a4c0903f53 [i18n/pt] Fix typo 2020-06-30 17:24:50 +02:00
Gabriel Ozouf
e78c5c02d3 [apps/calculation] Fixed history scroll
Fixed a bug involving mishandled negative offsets in
CalculationSelectableTableView::scrollToSubviewOfTypeOfCellAtLocation
and cleaned up the function.

Change-Id: I4394ca9dc9748e8b761e7f722e41014d71d3373f
2020-06-30 15:41:56 +02:00
Émilie Feral
cb62747e48 build: Version 14.2.0 2020-06-26 17:48:31 +02:00
Émilie Feral
96c7d84633 [apps/calculation] Factorize code to avoid selecting ellipsis on cell
where ellipsis is not displayed
2020-06-26 17:48:31 +02:00
Émilie Feral
1281a4a508 [apps/calculation] HistoryController: avoid duplicate code when handling
backspace event. Keep the same selected subview.
2020-06-26 17:48:31 +02:00
Émilie Feral
94d3ac9828 [apps/calculation] HistoryController: fix order of actions in Backspace
handle event

This fixes the following bug: input 1/2/3/4/5/6/7/8, OK, OK, input 1,
OK, up, backspace. The selection disappeared.
2020-06-26 17:48:31 +02:00
Émilie Feral
aef804d149 [apps/calculation] HistoryController: avoid 2 calls to
setSelectedSubviewType in tableViewDidChangeSelectionAndDidScroll
2020-06-26 17:48:31 +02:00