UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-18 21:30:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps/proba] Fisher distribution authorized parameter values

Browse Source
This commit is contained in:
Léa Saviot
2020-01-14 11:09:35 +01:00
parent 8c801392a5
commit 0260e2ffb4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/probability/distribution/fisher_distribution.cpp
View File

@@ -53,12 +53,11 @@ float FisherDistribution::evaluateAtAbscissa(float x) const {
bool FisherDistribution::authorizedValueAtIndex(float x, int index) const {
assert(index == 0 || index == 1);
return x > FLT_MIN; // TODO LEA Add max limit? See NormalDistribution
return x > FLT_MIN && x <= k_maxParameter;
}
void FisherDistribution::setParameterAtIndex(float f, int index) {
TwoParameterDistribution::setParameterAtIndex(f, index);
// TODO LEA Adjust parameter if max definition ? See NormalDistribution
}
double FisherDistribution::cumulativeDistributiveFunctionAtAbscissa(double x) const {

1
apps/probability/distribution/fisher_distribution.h
View File

@@ -22,6 +22,7 @@ public:
double cumulativeDistributiveFunctionAtAbscissa(double x) const override;
double cumulativeDistributiveInverseForProbability(double * probability) override;
private:
constexpr static float k_maxParameter = 144.0f; // The display works badly for d1 = d2 > 144.
constexpr static float k_defaultMax = 3.0f;
float mode() const;
};