UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-18 21:30:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/n_ary_expression] Do not compute numberOfChildren repeatedly

Browse Source
This commit is contained in:
Ruben Dashyan
2020-02-10 12:54:12 +01:00
committed by Léa Saviot
parent 466f588a99
commit 13391d486e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
poincare/src/n_ary_expression.cpp
View File

@@ -25,9 +25,10 @@ bool NAryExpressionNode::childAtIndexNeedsUserParentheses(const Expression & chi
void NAryExpressionNode::sortChildrenInPlace(ExpressionOrder order, Context * context, bool canSwapMatrices, bool canBeInterrupted) {
Expression reference(this);
for (int i = 1; i < reference.numberOfChildren(); i++) {
const int childrenCount = reference.numberOfChildren();
for (int i = 1; i < childrenCount; i++) {
bool isSorted = true;
for (int j = 0; j < reference.numberOfChildren()-1; j++) {
for (int j = 0; j < childrenCount-1; j++) {
/* Warning: Matrix operations are not always commutative (ie,
* multiplication) so we never swap 2 matrices. */
ExpressionNode * cj = childAtIndex(j);