Ruben Dashyan
0c4434d088
[poincare/expression] getUnit returns an uninitialized Expression
...
when there is no Unit instead of Undefined
2020-06-04 14:50:01 +02:00
Ruben Dashyan
f5b964339c
[poincare/test/expression_properties] Fix helper assert_reduced_expression_unit
...
First reduce
Then getUnit
2020-06-04 14:50:01 +02:00
Ruben Dashyan
2fea3c9b3a
[poincare/addition] Addition has no Unit
2020-06-04 14:50:01 +02:00
Ruben Dashyan
121e16a6a5
[poincare/absolute_value] AbsoluteValue has no Unit
...
shallowReduce returns Undefined if its unique child has a Unit
2020-06-04 14:50:01 +02:00
Ruben Dashyan
032723eae1
[poincare/layout_node] Remove unused variable
2020-06-04 14:50:01 +02:00
Ruben Dashyan
8365735f98
[apps/calculation/additional_outputs/expression_list_controller] Computed Layouts must not be uninitialized
2020-06-04 14:50:01 +02:00
Ruben Dashyan
a31524173f
[apps/calculation/history_controller] Factor handleEvent
2020-06-04 14:50:01 +02:00
Ruben Dashyan
a3265996fe
[apps/calculation/history_controller] Factor handleEvent
2020-06-04 14:50:01 +02:00
Ruben Dashyan
f3bcedd43d
[apps/calculation/history_controller] Simplify and harmonize handleEvent
2020-06-04 14:50:01 +02:00
Ruben Dashyan
167827f0e4
[apps/calculation] EditExpressionController accesses subview directly
2020-06-04 14:50:01 +02:00
Ruben Dashyan
63ab8710b9
[apps/calculation] Factor EditExpressionController::insertTextBody
2020-06-04 14:50:01 +02:00
Ruben Dashyan
145381ad4b
[apps/calculation/additional_outputs] Remove parentResponder parameter from ListControllers' constructor
...
which was always set to nullptr
2020-06-04 14:50:01 +02:00
Ruben Dashyan
e018c9ddc8
[poincare/trigonometry_cheat_table] Reorder parameter names correctly
2020-06-04 14:50:01 +02:00
Ruben Dashyan
b8993eafa9
[poincare/expression] Call reduce instead of deepReduce
2020-06-04 14:50:01 +02:00
Ruben Dashyan
8e71e03b6e
[poincare] Remove ostream and iostream header inclusions and keep them precisely where needed
2020-06-04 14:50:01 +02:00
Ruben Dashyan
b05202f2ec
[poincare] Remove stdio.h inclusions
2020-06-04 14:50:01 +02:00
Ruben Dashyan
e03c628381
[poincare/multiplication] shallowBeautify builds Unit only if necessary
2020-06-04 14:50:01 +02:00
Ruben Dashyan
e43362eee0
[poincare/multiplication] Factor CanSimplifyUnitProduct
2020-06-04 14:50:01 +02:00
Ruben Dashyan
9cbbffcdd6
[poincare/multiplication] shallowBeautify builds Power only if necessary
2020-06-04 14:50:01 +02:00
Ruben Dashyan
94bad10ddb
[poincare/multiplication] CanSimplifyUnitProduct gets int8_t entryUnitExponent parameter instead of operationOnExponents
2020-06-04 14:50:00 +02:00
Ruben Dashyan
79a81968c8
[poincare/unit] Avoid cloning expression in Dimension::Vector::FromBaseUnits
2020-06-04 14:50:00 +02:00
Ruben Dashyan
2f708cc36c
[poincare/unit] Dimension::Vector::FromBaseUnits accepts only products of powers of base units
...
and no other factor at all
2020-06-04 14:50:00 +02:00
Ruben Dashyan
394e86a28a
[poincare] Unit::Dimension holds a Vector
...
The Vector does not need to be recomputed from a Representative's
definition, which requires parsing and time-consuming reduction.
2020-06-04 14:50:00 +02:00
Ruben Dashyan
d7dab2ae99
[poincare/multiplication] bestUnitNorm not necessary anymore
2020-06-04 14:50:00 +02:00
Ruben Dashyan
191680d96f
[poincare/multiplication] Simplify Unit::Dimension::Vector::Metrics comparison
2020-06-04 14:50:00 +02:00
Ruben Dashyan
67241bb564
[poincare] Make code more object oriented
...
Turn ExponentsOfBaseUnits function into a static method of the
Unit::Dimension::Vector class
2020-06-04 14:50:00 +02:00
Ruben Dashyan
b6d07cbd90
[poincare] Make code more object oriented
...
Turn ExponentsOfBaseUnits function into a method of the
Unit::Dimension::Vector class
2020-06-04 14:50:00 +02:00
Ruben Dashyan
e2cdf78605
[poincare] Define and use Unit::Dimension::Vector::Metrics
2020-06-04 14:50:00 +02:00
Ruben Dashyan
2f6770cd69
[poincare/multiplication] Change signature of ExponentsOfBaseUnits
2020-06-04 14:50:00 +02:00
Ruben Dashyan
0eb6df27dc
[poincare] Turn Unit::Dimension::Vector type into a struct
2020-06-04 14:50:00 +02:00
Ruben Dashyan
202beb3b13
[poincare/unit] Add comment about namespace and scope usage
2020-06-04 14:50:00 +02:00
Ruben Dashyan
2fa71e4350
[poincare] Define and use Unit::NumberOfBaseUnits instead of magic number
2020-06-04 14:50:00 +02:00
Ruben Dashyan
be2892eae5
[poincare] Define Unit::Dimension::Vector type
2020-06-04 14:50:00 +02:00
Ruben Dashyan
157d74c0da
[poincare/unit] Coding style
2020-06-04 14:50:00 +02:00
Ruben Dashyan
f01f91d000
[poincare/unit] Clean serialize
...
The prefix should be correct at that point and it should not be
necessary to check whether the prefix is allowed.
2020-06-04 14:50:00 +02:00
Ruben Dashyan
bc0b21463e
[quiz][ion/test] Move time measurements to quiz
...
to be able to do measurements in any test
2020-06-04 14:50:00 +02:00
Léa Saviot
068ed96d79
[apps/range_1D] Add comment abour k_minFloat
2020-06-04 14:50:00 +02:00
Léa Saviot
ed753b793b
[apps/statistics] Do not initRangeParameters too often
2020-06-04 14:50:00 +02:00
Léa Saviot
51b5edbe69
[apps/statistics] Remove too strict condition
...
One could not set the bin with / x start to a value that would not show
any data
-> The condition was asymetrical, as nextFirstDrawnBarAbscissa could not
be higher to the biggest data, but could have been too small to display
any data
-> We restricted the user
2020-06-04 14:50:00 +02:00
Léa Saviot
59aea9ca83
[apps/statistics] Factorize HistogramParamCtrlr::setParamAtIdx
2020-06-04 14:50:00 +02:00
Léa Saviot
250f4ec3dd
[apps/statistics] Clean code
2020-06-04 14:50:00 +02:00
Léa Saviot
93d687abc2
[apps/calculation] Fix height computation in additional results
2020-06-04 05:47:55 -07:00
Émilie Feral
884d9890cf
[.github/workflow] ci-workflow: update setup-emscripten to v2
2020-06-04 09:37:11 +02:00
Joachim Le Fournis
899e0d4a6b
[apps/shared] Fixed a small mistake in parameter_text_field_delegate.cpp
...
In this commit, there was a small oversight in 7a4ee746b2 , which caused https://github.com/numworks/epsilon/issues/1570
2020-05-29 02:27:48 -07:00
Léa Saviot
b034f8e054
[apps/calculation] Fix history navigation
...
When calculations span on two lines, better selection
2020-05-28 04:44:27 -07:00
Léa Saviot
a56a73b0ba
[apps/calculation] Fix calculation height computation
...
It was done in two places before, which created inconsistencies
2020-05-28 04:44:27 -07:00
Léa Saviot
0379327b06
[apps/calculation] Geographic navigation in the history
2020-05-28 04:44:27 -07:00
Léa Saviot
1d3a949b6f
[apps/shared] Add escape case
2020-05-28 04:44:27 -07:00
Léa Saviot
e2f4b30b84
[apps/calculation] Remove unused variable
2020-05-28 04:44:27 -07:00
Léa Saviot
c4908c2bd9
[apps/calculation] Fix bottom calculation margin
...
Scenario: enter a calculation that uses two lines, the margin on the
bottom is too big
2020-05-28 04:44:27 -07:00